javascript - using id="submit" twice on one page -

-

i creating login/register part site. , login , register forms on page.

like:

<form name="loginform" style="text-align:center;" method="post" onsubmit="return validateform();" action="index.php">                 <div class="row">                         <input type="text" name="email" id="email" autocomplete="off" placeholder="email address" />                 </div>                 <br />                 <div class="row">                         <input type="password" name="password" id="password" autocomplete="off" placeholder="password" />                 </div>                 <br />                 <div class="row">                     <button id="submit" type="submit" class="button large arrow-type-2 dark">log me in</button>                 </div>             </form>   <form name="registerform" style="text-align:center;" method="post" onsubmit="return validatethisform();" action="index.php">                     <div class="row">                             <input type="text" name="email" id="email2" autocomplete="off" placeholder="email address"/>                     </div>                     <br />                     <div class="row">                             <input type="password" name="password" id="password2" autocomplete="off" placeholder="password"/>                     </div>                     <br />                     <div class="row">                         <button id="submit" type="submit" class="button large arrow-type-2 dark">create free account</button>                     </div>                 </form>

my js validation is: ( needs work )

function validateform()         {         var x=document.forms["loginform"]["email"].value;         var atpos=x.indexof("@");         var dotpos=x.lastindexof(".");         if (atpos<1 || dotpos<atpos+2 || dotpos+2>=x.length)           {           alert("not valid e-mail address");           return false;           }          var x=document.forms["loginform"]["password"].value;             if (x==null || x=="")               {               alert("please enter password");               return false;               }         }         function validatethisform()         {         var x=document.forms["registerform"]["email2"].value;         var atpos=x.indexof("@");         var dotpos=x.lastindexof(".");         if (atpos<1 || dotpos<atpos+2 || dotpos+2>=x.length)           {           alert("not valid e-mail address");           return false;           }          var x=document.forms["registerform"]["password2"].value;             if (x==null || x=="")               {               alert("please enter password");               return false;               }         }

the issue have page validation, works perfect. because have duplicate submit id's , need clean up.

can offer suggestions on improving code above ?

/////////////////////////////////////////

using: code below cross browser placeholder

$('[placeholder]').focus(function() { var input = $(this);  if (input.val() == input.attr('placeholder')) {    input.val('');    input.removeclass('placeholder');   }   }).blur(function() {   var input = $(this);   if (input.val() == '' || input.val() == input.attr('placeholder')) {     input.addclass('placeholder');     input.val(input.attr('placeholder'));    }   }).blur().parents('form').submit(function() {   $(this).find('[placeholder]').each(function() {    var input = $(this);    if (input.val() == input.attr('placeholder')) {      input.val('');     }    })    });

i simplified html code following:

<form name="loginform" method="post" onsubmit="return validateform();" action="index.php">     <label>email address: <input type="email" name="email" autocomplete="off" placeholder="email address"/></label>     <label>password: <input type="password" name="password" placeholder="password"/></label>     <button type="submit" class="button large arrow-type-2 dark">log in</button> </form>   <form name="registerform" method="post" onsubmit="return validatethisform();"       action="index.php">     <label>email address: <input type="email" name="email" autocomplete="off" placeholder="email address"/></label>     <label>password: <input type="password" name="password" placeholder="password"/></label>     <button type="submit" class="button large arrow-type-2 dark">create free account</button> </form>

points

  • always include label. not browsers support html5 placeholders.

  • all ids here reluctant. forms can accessed by

    var loginform = document.forms.loginform; //by name

    and form elements 

    loginform.email; //also name
  • no need divs , brs manage line breaks. use labels themselves. add display: block; necessary.
  • don't use inline style attribute. use css <style> element or external stylesheet.
  • there's no autocomplete on password fields.
  • use html5's new form input types. type="email" have browser natively validate field , notify user if email not valid.
  • keep simple. no need bloating.

Comments

Post a Comment

Popular posts from this blog

django - How can I change user group without delete record -

-
on website user have 1 group. , user can change group. it's made user.groups.clear() and user.groups.add(new_group) but it's not efficient, because there 2 sql query: delete, insert. how can change group update query? user , group related each other using manytomanyfield . means intersection table exists relating both entities, , if don't specify model map (using through attribute) django creates 1 you. looking @ sources django.contrib.auth.models see that's case. fortunatly, can access intermediary model using through attribute of manager (in case, user.groups.through ). can use regular model. example: >>> alice = user.objects.create_user('alice', 'alice@example.com', 'alicepw') >>> employee = group.objects.create(name='employee') >>> manager = group.objects.create(name='manager') >>> alice.groups.add(employee) >>> alice.groups.all() [<group: employee...
Read more

java - Need to add SOAP security token -

-
i need set custom soap header attribute on jax-ws generated webservice client. case webservice calls must go through proxy server requiring specific token (recieved web request header) present in soap request header. e.g.: 1 carserviceservice service = null; 2 service = new carserviceservice(new url(url), new qname(qname); 3 carserviceendpoint port = service.getcarserviceport(); it seems in line 3 wsdl retrieved , call fails due missing security token. 1 point direction on how done? a detailed example has been mentioned here: creating , deploying jax-ws web service on tomcat 6 this article shows how create , use security token .
Read more

java - EclipseLink JPA Object is not a known entity type -

-
i have strange problem eclipselink , object want persist. have 1 object (keypointlistimpl) stores object keypointimpl in list. persisting keypointimpl objects works great if try persist keypointlistimpl object java.lang.illegalargumentexception says object keypointimpl isn't known entity type. here keypointimpl code: @entity @table(name="keypoints") public class keypointimpl implements keypoint { @id @generatedvalue(strategy = generationtype.identity) private int id; @enumerated(enumtype.string) private detectortype keypointtype; private float x; private float y; private float size; private float angle; private float response; private int octave; private int classid; ... } here keypointlistimpl code: @entity @table(name="keypointlists") public class keypointlistimpl implements keypointlist { @id @generatedvalue(strategy = generationtype.identity) private int id; @onetoone(cascade={ca...
Read more