c# - pausing and stopping threads -

-

i have following code working dirty. code fine except part added: pause , stop button. i'm new c# apreciated.

    private void pause_button_click(object sender, eventargs e)     {         start = false; pause = true; stop = false;         guiupdate();         pauseevent.reset();     }      private void stop_button_click(object sender, eventargs e)     {         if (pause == true)         {             pauseevent.set();             pause = false;             this.start_button.click -= new system.eventhandler(this.resume_button_click);         }         start = false; stop = true;     }      private int activethreads = 0;     private thread thread;     private void dowork(object sender)     {         string line = null;         ereader = new streamreader(my_list);                 {             lock (ereader)             {                 pauseevent.waitone();                 line = ereader.readline();             }              //             //other commands processing & building argument             //              lock (signal)             {                 ++activethreads;             }              thread = new thread(new parameterizedthreadstart(                 o =>                 {                     processit((object)o);                     lock (signal)                     {                         --activethreads;                         monitor.pulse(signal);                     }                 }));             thread.start(argument);              lock (signal)             {                 while (activethreads > maxthreads)                     monitor.wait(signal);             }              lock (signal)             {                 if (!start)                 {                     showwaiting(true);//shows animated gif "please wait" msg                     while (activethreads > 0)                         monitor.wait(signal);                     showwaiting(false);                     if (stop == true)                     {                         this._backgroundworker.cancelasync();                         break;                     }                 }             }         }         while (ereader.peek() != -1);         showwaiting(true);         lock (signal)         {             while (activethreads > 0)                 monitor.wait(signal);         }         showwaiting(false);     }       private void _backgroundworker_runworkercompleted(object sender, runworkercompletedeventargs e)     {         start = false; stop = true;         guiupdate();     }

what can avoid duplicate commands inside , outside loop ?

mentioned in question comments suggestions code practice changes.

  • do not use == true or == false when checking boolean variable in condition. (jeff)
  • use enumerate represent state instead of multiple boolean variables.

i add:

  • use proper c# naming conventions. methods if there multiple words, capitalize words. (e.g. instead of showwaiting use showwaiting).

for small loops, don't need optimize them out though there more simple loop. refactor them separate method along code same:

private void showandwait() {     showwaiting(true);     lock (signal)     {         while (activethreads > 0)             monitor.wait(signal);     }     showwaiting(false); }

note fine same thread lock on monitor acquired. fast operation since thread owns lock. can call method both places.


Comments

Post a Comment

Popular posts from this blog

django - How can I change user group without delete record -

-
on website user have 1 group. , user can change group. it's made user.groups.clear() and user.groups.add(new_group) but it's not efficient, because there 2 sql query: delete, insert. how can change group update query? user , group related each other using manytomanyfield . means intersection table exists relating both entities, , if don't specify model map (using through attribute) django creates 1 you. looking @ sources django.contrib.auth.models see that's case. fortunatly, can access intermediary model using through attribute of manager (in case, user.groups.through ). can use regular model. example: >>> alice = user.objects.create_user('alice', 'alice@example.com', 'alicepw') >>> employee = group.objects.create(name='employee') >>> manager = group.objects.create(name='manager') >>> alice.groups.add(employee) >>> alice.groups.all() [<group: employee...
Read more

java - Need to add SOAP security token -

-
i need set custom soap header attribute on jax-ws generated webservice client. case webservice calls must go through proxy server requiring specific token (recieved web request header) present in soap request header. e.g.: 1 carserviceservice service = null; 2 service = new carserviceservice(new url(url), new qname(qname); 3 carserviceendpoint port = service.getcarserviceport(); it seems in line 3 wsdl retrieved , call fails due missing security token. 1 point direction on how done? a detailed example has been mentioned here: creating , deploying jax-ws web service on tomcat 6 this article shows how create , use security token .
Read more

java - EclipseLink JPA Object is not a known entity type -

-
i have strange problem eclipselink , object want persist. have 1 object (keypointlistimpl) stores object keypointimpl in list. persisting keypointimpl objects works great if try persist keypointlistimpl object java.lang.illegalargumentexception says object keypointimpl isn't known entity type. here keypointimpl code: @entity @table(name="keypoints") public class keypointimpl implements keypoint { @id @generatedvalue(strategy = generationtype.identity) private int id; @enumerated(enumtype.string) private detectortype keypointtype; private float x; private float y; private float size; private float angle; private float response; private int octave; private int classid; ... } here keypointlistimpl code: @entity @table(name="keypointlists") public class keypointlistimpl implements keypointlist { @id @generatedvalue(strategy = generationtype.identity) private int id; @onetoone(cascade={ca...
Read more