ruby on rails - How to DRY scope methods used in two different classes? -

-

i using ruby on rails 3.2.2 , retrieve / scope associated objects "specifying" / "filtering on" attribute value on associated objects. is, @ time using following code:

class article < activerecord::base   def self.search_by_title(search)     where('articles.title ?', "%#{search}%")   end end  class articleassociation < activerecord::base   def self.search_by_article_title(search)     joins(:article).where('articles.title ?', "%#{search}%")   end end

in above code where('articles.title ?', "%#{search}%") clause repeated twice , thought may improved dry principle: is possible use the article.search_by_title method directly in the articleassociation.search_by_article_title method?

typical use cases are:

  • articleassociation.search_by_article_title("sample string")
  • article.search_by_title("sample string")

unless change code structure completely, no.

you hacking lambdas, more code code you're drying. there such thing refactoring, , such thing bad refactoring. unless piece of very complex or long code used in 2 or more places, can worry refactoring. code conventions important, tiny one-method-call things waste , make code more cryptic.

though, know it's annoying when people don't answer question, here:

class article < activerecord::base   search_by_title=lambda {|obj, search| obj.where('articles.title ?', "%#{search}%")}   def self.search_by_title(search)     search_by_title.call(self, search)   end end  class articleassociation < activerecord::base   def self.search_by_article_title(search)     article::search_by_title.call(joins(:article),search)   end end

that makes lambda constant performs where call on specified object. both methods wrap lambda.

note: although may considered more elegant, decrease performance lot, lambdas, closures, , call expensive in dynamic language ruby. don't think that's issue you.


Comments

Post a Comment

Popular posts from this blog

django - How can I change user group without delete record -

-
on website user have 1 group. , user can change group. it's made user.groups.clear() and user.groups.add(new_group) but it's not efficient, because there 2 sql query: delete, insert. how can change group update query? user , group related each other using manytomanyfield . means intersection table exists relating both entities, , if don't specify model map (using through attribute) django creates 1 you. looking @ sources django.contrib.auth.models see that's case. fortunatly, can access intermediary model using through attribute of manager (in case, user.groups.through ). can use regular model. example: >>> alice = user.objects.create_user('alice', 'alice@example.com', 'alicepw') >>> employee = group.objects.create(name='employee') >>> manager = group.objects.create(name='manager') >>> alice.groups.add(employee) >>> alice.groups.all() [<group: employee...
Read more

java - Need to add SOAP security token -

-
i need set custom soap header attribute on jax-ws generated webservice client. case webservice calls must go through proxy server requiring specific token (recieved web request header) present in soap request header. e.g.: 1 carserviceservice service = null; 2 service = new carserviceservice(new url(url), new qname(qname); 3 carserviceendpoint port = service.getcarserviceport(); it seems in line 3 wsdl retrieved , call fails due missing security token. 1 point direction on how done? a detailed example has been mentioned here: creating , deploying jax-ws web service on tomcat 6 this article shows how create , use security token .
Read more

java - EclipseLink JPA Object is not a known entity type -

-
i have strange problem eclipselink , object want persist. have 1 object (keypointlistimpl) stores object keypointimpl in list. persisting keypointimpl objects works great if try persist keypointlistimpl object java.lang.illegalargumentexception says object keypointimpl isn't known entity type. here keypointimpl code: @entity @table(name="keypoints") public class keypointimpl implements keypoint { @id @generatedvalue(strategy = generationtype.identity) private int id; @enumerated(enumtype.string) private detectortype keypointtype; private float x; private float y; private float size; private float angle; private float response; private int octave; private int classid; ... } here keypointlistimpl code: @entity @table(name="keypointlists") public class keypointlistimpl implements keypointlist { @id @generatedvalue(strategy = generationtype.identity) private int id; @onetoone(cascade={ca...
Read more